Get event context on EventSubscription #423
Conversation
|
I'm happy with the general idea (though I think If you're keen on exposing these details sooner then I'd be happy for this to progress and get merged in the meantime. |
lamafab
force-pushed
the
event-context
branch
from
c3d85fb to
8ff7f2f
Compare
src/subscription.rs
Outdated
| pub struct EventContext<T> { | ||
| pub block: T, |
There was a problem hiding this comment.
How about:
| pub struct EventContext<T> { | |
| pub block: T, | |
| pub struct EventContext<Hash> { | |
| pub block_hash: Hash, |
There was a problem hiding this comment.
Yep, done! Also rebased to master.
lamafab
force-pushed
the
event-context
branch
from
8ff7f2f to
a615b79
Compare
|
Had to rebase twice, missed your second push to master :) |
|
Awesome; CI runs approved so we can see how it goes. Given this PR and comments on #413 I'll start work on simplfying this |
|
@jsdw I would appreciate it if you could get this merged. I'm okay if you'll eventually replace it :) |
|
@lamafab if you could resolve the small cargo fmt errors (run |
|
@jsdw done, please run the workflows. |
* implement next_context * write test_context for method next_context * change how events are uniquely identified * undo local changes for test-runtime * introduce EventContext struct * adjust test_context to EventContext struct * fix return type for next_context * add suggestions by jsdw * ran cargo fmt and clippy
Currently, the
nextmethod on theEventSubscriptiontype only returns the event itself, not clarifying where it occurred. This PR introduces a new method,next_context, that additionally returns the corresponding block hash and the index of the event.Btw, I think it would be great to have a block number, too, but I think that'd require upstream substrate changes (or additional queries on
subxt's side).Feedback/criticism appreciated.
EDIT: Will wait for your feedback before I'll resolve the conflicts.